Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python interpreter key #1061

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fix python interpreter key #1061

merged 1 commit into from
Dec 1, 2021

Conversation

minwhoo
Copy link
Contributor

@minwhoo minwhoo commented Nov 19, 2021

Fix python interpreter key.

ansible.cfg should use interpreter_python as documented in https://docs.ansible.com/ansible/2.9/reference_appendices/interpreter_discovery.html

@ajdecon
Copy link
Collaborator

ajdecon commented Nov 22, 2021

@minwhoo This looks reasonable to me!

Can you please sign-off on your commit to agree to our Developer Certificate of Origin, as documented in our CONTRIBUTING.md document? This will allow us to accept your PR.

You can do this in your existing PR by running the following in your local DeepOps clone with the branch for this PR:

# Check out branch for this PR
$ git checkout patch-1

# Amend your previous commit to sign off
$ git commit --amend --signoff

# Force-push the branch to update the PR
$ git push --force

Fix python interpreter key.

ansible.cfg should use `interpreter_python` as documented in https://docs.ansible.com/ansible/2.9/reference_appendices/interpreter_discovery.html

Signed-off-by: Minwoo Lee <minwoolee@snu.ac.kr>
@minwhoo
Copy link
Contributor Author

minwhoo commented Nov 24, 2021

No problem. Done!

Copy link
Collaborator

@ajdecon ajdecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajdecon ajdecon merged commit b5c83c2 into NVIDIA:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants