Adding Nvidia network operator for DGX #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| shell: kubectl label --overwrite nodes {{ item }} node-role.kubernetes.io/worker= | ||
| with_items: "{{ groups['kube-node']}}" | ||
|
|
||
| - name: Install openshift |
There was a problem hiding this comment.
Rather than install this here, add the existing openshift role as a dep. See roles/nvidia-gpu-operator/meta/main.yml for an example.
There was a problem hiding this comment.
I actually tried that existing role but failed, we can take a closer look if taking that approach.
| kubernetes.core.helm: | ||
| name: network-operator | ||
| release_namespace: network-operator | ||
| chart_version: 1.1.0 |
There was a problem hiding this comment.
These should all be parameterized as variables like we do in the GPU Operator playbook.
There was a problem hiding this comment.
Good call, will move it to variable file.
Removed a debug variable.
ajdecon
reviewed
Feb 16, 2022
| - name: Install latest Kubeflow MPI-Operator | ||
| k8s: | ||
| state: present | ||
| definition: "{{ lookup('url', 'https://raw.githubusercontent.com/kubeflow/mpi-operator/master/deploy/{{mpi_operator_version}}/mpi-operator.yaml', split_lines=False) }}" |
There was a problem hiding this comment.
Like the split into variables.
Let's consider making the URL a variable too in case we create an internal fork in the future.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.