Fix multi-node K8s deployment script #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdecon
approved these changes
Mar 23, 2022
supertetelman
commented
Mar 23, 2022
| # # GPU Device Plugin is installed into kube-system, GPU Operator installs it into gpu-operator-resources | ||
| plugin_namespace=$( kubectl get pods -A -l app.kubernetes.io/instance=nvidia-device-plugin --no-headers --no-headers -o custom-columns=NAMESPACE:.metadata.namespace) | ||
| # # GPU Device Plugin is installed into kube-system, GPU Operator installs it into gpu-operator-resources, use uniq for HA K8s clusters | ||
| plugin_namespace=$( kubectl get pods -A -l app.kubernetes.io/instance=nvidia-device-plugin --no-headers --no-headers -o custom-columns=NAMESPACE:.metadata.namespace | uniq) |
There was a problem hiding this comment.
Ran into this bug where kubectl was reporting multiple pods in HA clusters causing the dcgm-exporter install not to trigger.
dholt
approved these changes
Mar 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent upgrade to support GPU Operator end-to-end I introduced a bug in the HA K8s deployments. This resulted in DCGM-exporter not being deployed.
This PR simply fixes that script bug and also causes the test-monitoring.sh script to fail a bit faster when an error does occur.