Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ansible Galaxy dependencies to address Molecule test failures #1158

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

ajdecon
Copy link
Collaborator

@ajdecon ajdecon commented Apr 14, 2022

Summary

  • Update community.general to 4.7.0
  • Pin Ansible to 2.9.27 in Molecule tests
  • Add explicit dependency on community.docker

Context

Starting about a week ago, our Molecule tests started failing due to issues installing the community.general collection from Ansible Galaxy:

Downloading https://galaxy.ansible.com/download/community-general-3.0.0.tar.gz to /home/runner/.ansible/tmp/ansible-local-2080w4oiblig/tmp44egidyw/community-general-3.0.0-hz736f[97](https://github.com/NVIDIA/deepops/runs/5853868950?check_suite_focus=true#step:5:97)
Installing 'community.general:3.0.0' to '/home/runner/.ansible/collections/ansible_collections/community/general'
ERROR! Unable to extract 'tests/integration/targets/django_manage/files/base_test/1045-single-app-project/single_app_project/core/' from collection

It seems like something changed upstream which may be causing this, despite our version pinning.

It's not clear to me why this would be going on... but in any case, our version of community.general is pretty old anyway. We're on 3.0.0, and the most recent version is 4.7.0. This collection still maintains compatibility with Ansible 2.9 so we should be good to upgrade.

The remaining changes (pinning our Ansible version and making our community.docker dependency explicit) are rolled in to try and help keep these tests more stable.

Test plan

All of linting, Molecule tests, and Jenkins tests should pass.

@ajdecon ajdecon merged commit 90c1df4 into NVIDIA:master Apr 20, 2022
@ajdecon ajdecon mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants