Have same slurm.conf among nodes and controller #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share slurm.conf to have same of it - in case of configuring nodes and/or partitions. Locate slurm.conf at /sw/.slurm/slurm.conf of controller where the /sw is nfs mount point to all of nodes. Let /etc/slurm/slurm.conf be a soft link to it from nodes and controller. Signed-off-by: Seyong Um <seyong.um@hyundai.com>
ajdecon
requested changes
Jun 15, 2022
There was a problem hiding this comment.
@seyong-um : This functionality looks useful to support, and I know this is a common pattern in a lot of Slurm clusters.
However, I don't think we want to enable this by default, as we have several known use cases where the Slurm controller and the compute nodes don't share an NFS filesystem.
Would you be willing to put this behind a flag variable? I.e., add a boolean variable like slurm_conf_symlink which defaults to false, and only set up the symlink if it's set to true. Otherwise, use the existing logic.
The flag slurm_conf_symlink will allow modes to share slurm.conf via nfs. Signed-off-by: Seyong Um <seyong.um@hyundai.com>
|
I added share-slurm-conf flag as you suggested. The default value is false, it is existing logic, once it has been set to true then new logic will run. |
ajdecon
requested changes
Jun 16, 2022
Signed-off-by: Seyong Um <seyong.um@hyundai.com>
ajdecon
approved these changes
Jun 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share slurm.conf to have same of it - in case of configuring nodes and/or partitions.
Locate slurm.conf at /sw/.slurm/slurm.conf of controller where the /sw is nfs mount point to the all nodes.
Let /etc/slurm/slurm.conf be a soft link to it from nodes and controller.
By Hyundai Motor Group / AIRS Company
Signed-off-by: Seyong Um seyong.um@hyundai.com