Skip to content

Fix get P2PNVlinkType error #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elezar merged 1 commit into from
Dec 5, 2023
Merged

Fix get P2PNVlinkType error #16

elezar merged 1 commit into from
Dec 5, 2023

Conversation

@kerthcet
Copy link
Contributor

@kerthcet kerthcet commented Dec 5, 2023 •
edited
Loading

Please correct me if not right.

Since we want to get the nvlink amount in-between two devices, then we should skip if the busID not match.

@kerthcet
Fix get P2PNVlinkType error
52d9040 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet
Copy link
Contributor Author

kerthcet commented Dec 5, 2023

cc @elezar

elezar
elezar approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@elezar elezar merged commit 8fc3087 into NVIDIA:main Dec 5, 2023
@kerthcet kerthcet deleted the fix/get-nv-links branch December 5, 2023 15:31
@kerthcet
Copy link
Contributor Author

kerthcet commented Dec 5, 2023

Should this be cherry-picked?

@elezar
Copy link
Member

elezar commented Dec 5, 2023

Should this be cherry-picked?

That shouldn't be necessary. We have a single main branch for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elezar elezar elezar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kerthcet @elezar