Fix construction of linked devices #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change fixes the construction of the linked devices. Firstly, the nvmlDevices are used directly when determining link properties instead of relying on the local Device type. This allows the nvml Device handle to be used directly. In addition an ERROR_INVALID_ARGUMENT when querying link state is treated as a non-fatal error to handle cases where older drivers are used. This also aligns with the former implementation in gpu-monitoring-tools. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in NVIDIA/go-nvlib#16 the construction of the link information for devices fails as the
Devicepassed in is not annvmlDevice.These changes fix the implementation by making use of the changes from NVIDIA/go-nvlib#17 and ensuring that the list of NVML devices is kept separate from the linked devices.
A simple example is also added and was validated on two systems with multiple GPUs after verifying the reported behaviour.