Typed signatures for event handlers #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Patrin <ppatrin@nvidia.com>
Signed-off-by: Pavel Patrin <ppatrin@nvidia.com>
Signed-off-by: Pavel Patrin <ppatrin@nvidia.com>
pavelpatrin
changed the title
* Typed signatures for event handlers: variable args. Signed-off-by: Pavel Patrin <ppatrin@nvidia.com>
Signed-off-by: Pavel Patrin <ppatrin@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the event handler service in gontainer was quite primitive, allowing only one way to define an event handler with the
func(args ...any) [error]signature. This approach is not convenient when working with well-defined types directly in the function signature, such asfunc(arg1 string, arg2 int, arg3 bool) [error].This pull request enhances the gontainer by adding support for typed event handlers. Now, developers can define event handlers with specific argument types, making the code more readable and type-safe.