Skip to content

Commit

Permalink
unused aws instace and vpcs cleanup
Browse files Browse the repository at this point in the history
Signed-off-by: shiva kumar <shivaku@nvidia.com>
  • Loading branch information
shivakunv committed Dec 19, 2024
1 parent c6bbb06 commit 228422c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion tests/aws_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"github.com/NVIDIA/holodeck/pkg/jyaml"
"github.com/NVIDIA/holodeck/pkg/provider"
"github.com/NVIDIA/holodeck/pkg/provisioner"
"github.com/NVIDIA/holodeck/tests/common"
)

// Actual test suite
Expand All @@ -55,8 +56,8 @@ var _ = Describe("AWS", func() {
Expect(err).ToNot(HaveOccurred())

// Set unique name for the environment
// Set env name
common.setCfgName(&opts.cfg)
opts.cfg.Name = opts.cfg.Name + "-" + common.GenerateUID()
// set cache path
opts.cachePath = LogArtifactDir
// set cache file
Expand Down
7 changes: 4 additions & 3 deletions tests/common/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ func setCfgName(cfg *v1alpha1.Environment) {
if len(sha) > 8 {
sha = sha[:8]
}
// uid is unique for each run
uid := GenerateUID()
// // uid is unique for each run
// uid := GenerateUID()

cfg.Name = fmt.Sprintf("ci%s-%s-%s", attempt, sha, uid)
// cfg.Name = fmt.Sprintf("ci%s-%s-%s", attempt, sha, uid)
cfg.Name = fmt.Sprintf("ci%s-%s", attempt, sha)
}

0 comments on commit 228422c

Please sign in to comment.