Merge pull request #30 from NVIDIA/ghaction

Fix key handling again

cmd/action/ci/ci.go

@@ -28,16 +28,14 @@ const (
 	cachedir   = "/github/workspace/.cache"
 	cacheFile  = "/github/workspace/.cache/holodeck.yaml"
 	kubeconfig = "/github/workspace/kubeconfig"
-	sshKeyFile = "/github/workspace/.cache/key"
+	sshKeyFile = "/github/workspace/.cache/key.pem"
 	// Default EC2 instance UserName for ubuntu AMI's
 	username = "ubuntu"
 )
 
 func Run(log *logger.FunLogger) error {
-	log.Info("Running Holodeck function")
-	// Check if .cache folder exists in the /github/workspace directory and if it does, call cleanup function
-	// If it doesn't, call entrypoint function
-	// If the entrypoint function returns an error, call cleanup function
+	log.Info("Holodeck Settting up test environment")
+
 	if _, err := os.Stat(cachedir); err == nil {
 		if err := cleanup(log); err != nil {
 			return err

cmd/action/ci/cleanup.go

@@ -64,12 +64,17 @@ func cleanup(log *logger.FunLogger) error {
 	}
 
 	// Delete the cache kubeconfig and ssh key
-	if err := os.Remove(kubeconfig); err != nil {
-		log.Error(fmt.Errorf("error deleting kubeconfig: %s", err))
+	// if kubeconfig exists, delete it
+	if _, err := os.Stat(kubeconfig); err == nil {
+		if err := os.Remove(kubeconfig); err != nil {
+			log.Error(fmt.Errorf("error deleting kubeconfig: %s", err))
+		}
 	}
 
-	if err := os.Remove(sshKeyFile); err != nil {
-		log.Error(fmt.Errorf("error deleting ssh key: %s", err))
+	if _, err := os.Stat(sshKeyFile); err == nil {
+		if err := os.Remove(sshKeyFile); err != nil {
+			log.Error(fmt.Errorf("error deleting ssh key: %s", err))
+		}
 	}
 
 	if err := os.RemoveAll(cachedir); err != nil {

cmd/action/main.go

@@ -37,4 +37,7 @@ func main() {
 		os.Exit(1)
 	}
 
+	// Exit with success
+	// https://docs.github.com/en/actions/creating-actions/setting-exit-codes-for-actions
+	os.Exit(0)
 }