Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub metadata as AWS Tags #235

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add GitHub metadata as AWS Tags #235

merged 1 commit into from
Dec 19, 2024

Conversation

shivakunv
Copy link
Contributor

No description provided.

@shivakunv shivakunv force-pushed the ci-dynamicname branch 8 times, most recently from c4e124c to 3d43889 Compare December 13, 2024 06:11
shivakunv
shivakunv commented Dec 13, 2024
View reviewed changes
.github/dependabot.yml Outdated Show resolved Hide resolved
shivakunv
shivakunv commented Dec 13, 2024
View reviewed changes
.github/dependabot.yml Outdated Show resolved Hide resolved
shivakunv
shivakunv commented Dec 13, 2024
View reviewed changes
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
shivakunv
shivakunv commented Dec 13, 2024
View reviewed changes
.github/workflows/go.yml Outdated Show resolved Hide resolved
shivakunv
shivakunv commented Dec 13, 2024
View reviewed changes
.github/workflows/go.yml Outdated Show resolved Hide resolved
@shivakunv shivakunv force-pushed the ci-dynamicname branch 3 times, most recently from 974bb03 to 890030c Compare December 15, 2024 12:32
@shivakunv shivakunv marked this pull request as ready for review December 15, 2024 12:38
@shivakunv shivakunv self-assigned this Dec 15, 2024
shivakunv
shivakunv commented Dec 15, 2024
View reviewed changes
cmd/action/ci/ci.go Outdated Show resolved Hide resolved
@shivakunv shivakunv force-pushed the ci-dynamicname branch 2 times, most recently from cfdbee7 to aea8944 Compare December 17, 2024 13:25
@shivakunv
Copy link
Contributor Author

@cdesiniotis

cfg.Name = fmt.Sprintf("ci%s-%s-%s", attempt, sha, uid)

is required to maintain uniqueness (in case of workspace deletion or fork repo)

@shivakunv shivakunv force-pushed the ci-dynamicname branch 2 times, most recently from 9228476 to 971df34 Compare December 18, 2024 08:05
tariq1890
tariq1890 reviewed Dec 18, 2024
View reviewed changes
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
pkg/provider/aws/aws.go Show resolved Hide resolved
@tariq1890
Copy link
Contributor

@shivakunv Please change the PR Title and Commit message as Add GitHub metadata as AWS Tags

@shivakunv shivakunv changed the title meta data name support Add GitHub metadata as AWS Tags Dec 18, 2024
tariq1890
tariq1890 reviewed Dec 18, 2024
View reviewed changes
pkg/provider/aws/aws.go Outdated Show resolved Hide resolved
@shivakunv
Add GitHub metadata as AWS Tags
f1a0a0f 
Signed-off-by: shiva kumar <shivaku@nvidia.com>
@shivakunv shivakunv merged commit 6783298 into main Dec 19, 2024
5 checks passed
@tariq1890 tariq1890 deleted the ci-dynamicname branch December 19, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@elezar elezar Awaiting requested review from elezar elezar is a code owner

@cdesiniotis cdesiniotis Awaiting requested review from cdesiniotis cdesiniotis is a code owner

Assignees

@shivakunv shivakunv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivakunv @tariq1890 @cdesiniotis