Add ada architecture label for compute capability 8.9 #1060
Conversation
internal/lm/resource.go
Outdated
| if computeMinor < 9 { | ||
| return "ampere" | ||
| } | ||
| return "ada" |
There was a problem hiding this comment.
Should this be ada-lovelace? I saw your comment elsewhere on the CUDA samples using just Ada but I'm not sure if this is the correct source of truth to go by.
There was a problem hiding this comment.
There was a problem hiding this comment.
OK. I don't feel too strongly - it mostly just feels inconsistent. Especially since its shortened to "Ada" and not "Lovelace" since all others are the last name, not the first name.
There was a problem hiding this comment.
Updated to ada-lovelace and created NVIDIA/go-nvlib#49
elezar
force-pushed
the
add-ada-lovelace-label
branch
from
72dba88 to
03f25d4
Compare
|
Looks like this needs a rebase |
|
Side question -- should |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
add-ada-lovelace-label
branch
from
03f25d4 to
aaccdfd
Compare
In theory, yes. The issue is that we do support CUDA devices and we would need a bit of refactoring to use that directly. I have some thoughts on how to do that, but didn't want to address it in this PR. |
|
@klueska I have rebased the changes. PTAL. |
No description provided.