Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning when set memory limits check is pre-volta arch #797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add warning when set memory limits check is pre-volta arch #797

wants to merge 1 commit into from

Conversation

lengrongfu
Copy link

@elezar elezar self-assigned this Jul 9, 2024
elezar
elezar requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the warning shown as indicated.

Note that this does mean that there will be NO memory limits applied for pre-volta devices. Please update the commit message to indicate this too.

cmd/mps-control-daemon/mps/daemon.go Outdated Show resolved Hide resolved
@lengrongfu
Copy link
Author

OK

@lengrongfu
add warning when set memory limits valide is pre-volta arch
5978161 
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
@lengrongfu
Copy link
Author

lengrongfu commented Oct 2, 2024 •
edited
Loading

@elezar PTAL, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elezar elezar elezar requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@elezar elezar

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lengrongfu @elezar