This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
memcpy_async should cache only in L2 when possible #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes memcpy_async for 16 byte alignment from using ca (cache all) to using cg (cache global) hint and also specifies the size of the source.
gonzalobg
changed the title
wmaxey
added
testing: internal ci in progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds src sizes to memcpy_async specializations, and for the 16 byte alignment case, it changes the cache operator from caching at all levels, to only caching at the global L2 level.
After an app carves some shared memory out of the L1 and then copies data to that shared memory, chances are that it will only read that data from shared memory. Caching the data only in the L2, and not in the L1, seems like the better default.
Closes #135 .