This repository was archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griwes
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that the bit fiddling in here works and is verified by tests.
In addition to the inline comment - rename the tests in libcxx/test to match the names that actually ended up in the standard.
f27c861
to
bf3c697
Compare
5617f62
to
2ece95a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<cuda/std/bit> - C++20 backport of bit manipulation intrinsics
Allows manipulation of unsigned values using
<bit>
Details
Motivation
popc/clz/ctz
but they differ from host compiler builtins. Libcu++ has an opportunity to unify host and device code for these intrinsics.int128
in device code is not able to make use of CUDA intrinsics, this backport provides a general method for users to manipulate wider values.Impact
is_constant_evaluated
is required to improve performance where possible.Checklists
Testing