Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Use decimal notation for version number. #241

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Use decimal notation for version number. #241

merged 1 commit into from
Feb 12, 2022

Conversation

alliepiper
Copy link
Collaborator 

error: invalid digit "8" in octal constant
  001008000
  ^~~~~~~~~

@alliepiper
Use decimal notation for version number.
f339a1f 
```
error: invalid digit "8" in octal constant
  001008000
  ^~~~~~~~~
```
@alliepiper alliepiper requested a review from wmaxey January 18, 2022 22:37
@alliepiper alliepiper mentioned this pull request Jan 18, 2022
Merged
@wmaxey wmaxey added the enhancement New feature or request. label Jan 18, 2022
@wmaxey wmaxey added this to the 1.8.0 milestone Jan 18, 2022
@wmaxey wmaxey added testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Jan 21, 2022
wmaxey
wmaxey approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@wmaxey wmaxey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only took 8 versions of our 1.0 release to notice this bug. :)

@wmaxey wmaxey merged commit 0b33eb0 into NVIDIA:main Feb 12, 2022
@alliepiper alliepiper deleted the version_fix branch February 19, 2022 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wmaxey wmaxey wmaxey approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alliepiper @wmaxey