This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix several truncations and warnings in numerics #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griwes
reviewed
Mar 8, 2022
| @@ -53,10 +53,12 @@ int main(int, char**) | |||
| test<__int128_t>(0); | |||
| test<__uint128_t>(0); | |||
| #endif | |||
| #if !defined(_MSC_VER) | |||
There was a problem hiding this comment.
Why are these disabled on MSVC?
There was a problem hiding this comment.
Complaints of division by zero. I was going to @ you and ask about this one. Should we include host <cmath> and use some macro for INFINITY?
There was a problem hiding this comment.
Can we silence the warning with a pragma?
There was a problem hiding this comment.
This is an outright error:
C:\Users\wmaxey\Documents\temp\libcudacxx\.upstream-tests\test\std\language.support\support.limits\limits\numeric.limits.members\infinity.pass.cpp(56): error #39-D: division by zero
C:\Users\wmaxey\Documents\temp\libcudacxx\.upstream-tests\test\std\language.support\support.limits\limits\numeric.limits.members\infinity.pass.cpp(57): error #39-D: division by zero
There was a problem hiding this comment.
Hmm. Okay.
Yeah let's use INFINITY. I'd rather not have this commented out on MSVC.
There was a problem hiding this comment.
Updated in latest commit and tested on MSVC 14.30/16/12.
griwes
approved these changes
Mar 8, 2022
wmaxey
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some longstanding MSVC issues. No functional impact, but resolves a few warnings making tests build clean.
https://nvbugswb.nvidia.com/NVBugs5/redir.aspx?url=/3556730