This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Docker refactor, parameterizes OS and compiler versions. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
force-pushed
the
build/docker_refactor
branch
from
065362d to
5589926
Compare
wmaxey
force-pushed
the
build/docker_refactor
branch
from
5589926 to
7414de3
Compare
wmaxey
force-pushed
the
build/docker_refactor
branch
from
6e92dd2 to
72c032c
Compare
wmaxey
force-pushed
the
build/docker_refactor
branch
2 times, most recently
from
a19733e to
369fd23
Compare
miscco
reviewed
Jul 29, 2022
docker2/config.Dockerfile
Outdated
|
|
||
| ADD . /libcudacxx | ||
|
|
||
| # Install compiler and configure project |
There was a problem hiding this comment.
Does this really install the compiler?
docker2/driver.Dockerfile
Outdated
| # Released under the Apache License v2.0 with LLVM Exceptions. | ||
| # See https://llvm.org/LICENSE.txt for license information. | ||
|
|
||
| # ARG BASE_IMAGE=nvcr.io/nvidia/nvhpc:22.3-devel-cuda_multi-ubuntu20.04 |
There was a problem hiding this comment.
Should that be something conditional like below
if [ ${NVCXX_ENABLED} ]; then
BASE_IMAGE="nvcr.io/nvidia/nvhpc:22.3-devel-cuda_multi-ubuntu20.04"
else
BASE_IMAGE="nvcr.io/nvidia/cuda:11.7.0-devel-ubuntu22.04"
fi;
There was a problem hiding this comment.
There's no conditionals in dockerfiles, it can only be parameterized.
At least I think.
docker2/wrapper.sh
Outdated
| EMPTY_DIR=$(mktemp -d) | ||
|
|
||
| LIBCUDA=$(ldconfig -p | grep libcuda.so | tr ' ' '\n' | grep / | head -n 1 | tr '\n' ' ' | sed 's/ *$//') | ||
| LIBNVIDIAPTXJITCOMPILER=$(ldconfig -p | grep libnvidia-ptxjitcompiler.so | tr ' ' '\n' | grep / | head -n 1 | tr '\n' ' ' | sed 's/ *$//') |
There was a problem hiding this comment.
Could we add some underscores here to make it somewhat readable?
wmaxey
force-pushed
the
build/docker_refactor
branch
2 times, most recently
from
1233ac9 to
6e81028
Compare
* Works seemlessly with VSCode + Docker extension. * manual bringup: `docker compose up --profile clang-14` or whatever compiler
wmaxey
force-pushed
the
build/docker_refactor
branch
from
db268c9 to
2e34809
Compare
|
@miscco Give this a shot, on Windows + VSCode it's pretty stellar. |
wmaxey
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we instead generate one layer that handles all dialects.
CMake demands a CUDA Toolkit be present, currently internal builds of the runtime do not satisfy that requirement so we must still sync from nvcr.io.