This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
modularize_iterator
branch
2 times, most recently
from
November 7, 2022 10:16
d166f2b
to
6409733
Compare
There's more errors in the log, but if you use the GCC-12 docker profile you can see that building the libcxx project fails. |
miscco
force-pushed
the
modularize_iterator
branch
11 times, most recently
from
November 14, 2022 18:57
7c975bc
to
e0a3987
Compare
miscco
force-pushed
the
modularize_iterator
branch
3 times, most recently
from
November 25, 2022 10:56
0589958
to
b553d48
Compare
miscco
force-pushed
the
modularize_iterator
branch
from
December 2, 2022 16:04
b553d48
to
d0b292b
Compare
griwes
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments only, ship it.
...rs/predef.iterators/move.iterators/move.iter.ops/move.iter.op.index/difference_type.pass.cpp
Show resolved
Hide resolved
miscco
force-pushed
the
modularize_iterator
branch
5 times, most recently
from
December 16, 2022 10:19
ccf6ea0
to
2425f5e
Compare
While at it also deprecate it
While at it also deprecate it
miscco
force-pushed
the
modularize_iterator
branch
from
December 19, 2022 09:02
2425f5e
to
c190127
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modularizes the
<iterator>
header as done by libc++.This is a precursor to updating to a more recent state of the code and bringing in C++20 ranges machinery