Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Modularize <iterator> #330

Merged
merged 32 commits into from
Dec 20, 2022
Merged

Modularize <iterator> #330

merged 32 commits into from
Dec 20, 2022

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Nov 4, 2022

This modularizes the <iterator> header as done by libc++.

This is a precursor to updating to a more recent state of the code and bringing in C++20 ranges machinery

@miscco miscco force-pushed the modularize_iterator branch 2 times, most recently from d166f2b to 6409733 Compare November 7, 2022 10:16
@wmaxey
Copy link
Member

wmaxey commented Nov 8, 2022

#0 0.498 In file included from /libcudacxx/libcxx/include/__iterator/advance.h:16,
#0 0.498                  from /libcudacxx/libcxx/include/iterator:681,
#0 0.498                  from /libcudacxx/libcxx/include/memory:661,
#0 0.498                  from /libcudacxx/libcxx/include/any:84,
#0 0.498                  from /libcudacxx/libcxx/src/any.cpp:9:
#0 0.498 /libcudacxx/libcxx/include/__iterator/iterator_traits.h:16:10: fatal error: concepts: No such file or directory
#0 0.498    16 | #include <concepts>
#0 0.498       |          ^~~~~~~~~~
#0 0.498 compilation terminated.
#0 0.500 [ 34%] Building CXX object libcxx/src/CMakeFiles/cxx_shared.dir/iostream.cpp.o
#0 0.507 In file included from /libcudacxx/libcxx/include/__iterator/advance.h:16,
#0 0.507                  from /libcudacxx/libcxx/include/iterator:681,
#0 0.507                  from /libcudacxx/libcxx/include/memory:661,
#0 0.507                  from /libcudacxx/libcxx/include/any:84,
#0 0.507                  from /libcudacxx/libcxx/src/any.cpp:9:
#0 0.507 /libcudacxx/libcxx/include/__iterator/iterator_traits.h:16:10: fatal error: concepts: No such file or directory
#0 0.507    16 | #include <concepts>
#0 0.507       |          ^~~~~~~~~~
#0 0.507 compilation terminated.

There's more errors in the log, but if you use the GCC-12 docker profile you can see that building the libcxx project fails.

@miscco miscco force-pushed the modularize_iterator branch 11 times, most recently from 7c975bc to e0a3987 Compare November 14, 2022 18:57
@miscco miscco force-pushed the modularize_iterator branch 3 times, most recently from 0589958 to b553d48 Compare November 25, 2022 10:56
@miscco miscco changed the base branch from main to modularize_type_traits December 2, 2022 16:05
Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only, ship it.

@miscco miscco force-pushed the modularize_iterator branch 5 times, most recently from ccf6ea0 to 2425f5e Compare December 16, 2022 10:19
@miscco miscco added the testing: internal ci passed Passed internal NVIDIA CI (DVS). label Dec 19, 2022
@miscco miscco changed the base branch from modularize_type_traits to main December 19, 2022 09:01
@miscco miscco merged commit 25658c1 into NVIDIA:main Dec 20, 2022
@miscco miscco deleted the modularize_iterator branch December 20, 2022 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants