This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Modularize <type_traits> #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
modularize_type_traits
branch
3 times, most recently
from
77514de to
21e8f82
Compare
griwes
reviewed
Dec 7, 2022
include/cuda/std/detail/libcxx/include/__type_traits/is_array.h
Outdated
Show resolved
Hide resolved
include/cuda/std/detail/libcxx/include/__type_traits/is_reference.h
Outdated
Show resolved
Hide resolved
.upstream-tests/test/std/utilities/meta/meta.unary/meta.unary.prop/is_literal_type.pass.cpp
Show resolved
Hide resolved
include/cuda/std/detail/libcxx/include/__type_traits/is_pointer.h
Outdated
Show resolved
Hide resolved
miscco
added
the
testing: internal ci in progress
griwes
approved these changes
Dec 9, 2022
miscco
force-pushed
the
modularize_type_traits
branch
2 times, most recently
from
98b03c2 to
de07bf9
Compare
miscco
force-pushed
the
modularize_type_traits
branch
from
a639f39 to
615cbf8
Compare
we missed some annotations and NODEBUG is a nice trait... fixed all include handlings
miscco
force-pushed
the
modularize_type_traits
branch
from
615cbf8 to
4c38345
Compare
miscco
added
testing: internal ci passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes ahead and rips type_traits apart. We will need this eventually for ranges, as otherwise the required changes become a mess