Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fetch host <utility> to populate tuple_size #336

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Fetch host <utility> to populate tuple_size #336

merged 2 commits into from
Dec 1, 2022

Conversation

wmaxey
Copy link
Member

@wmaxey wmaxey commented Dec 1, 2022

No description provided.

@wmaxey wmaxey requested a review from miscco December 1, 2022 01:30
@miscco
Copy link
Collaborator

miscco commented Dec 1, 2022 •
edited
Loading

Could you also then remove the forward declarations inside of array and tuple?

EDIT:

scratch that we need it in case of no host STL

jrhemstad
jrhemstad reviewed Dec 1, 2022
View reviewed changes
include/cuda/std/tuple Outdated Show resolved Hide resolved
jrhemstad
jrhemstad reviewed Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to add #include <utility> to cuda/std/array too?

@miscco
Copy link
Collaborator

miscco commented Dec 1, 2022

<array> already includes <utility>

@wmaxey @jrhemstad
Add more words to make intent clearer for why the host standard libra…
62bdefa 
…ry is necessary.

Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
@wmaxey wmaxey merged commit 853bbee into main Dec 1, 2022
@wmaxey wmaxey deleted the bugfix/tuple_array_ctad branch December 1, 2022 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrhemstad jrhemstad jrhemstad left review comments

@miscco miscco miscco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wmaxey @miscco @jrhemstad