-
Notifications
You must be signed in to change notification settings - Fork 187
Conversation
docs/extended_api/asynchronous_operations_library/memcpy_async.md
Outdated
Show resolved
Hide resolved
dde06ca
to
8d29c49
Compare
I think this is ready to be reviewed in depth. The rendered version of this PR is available here: Note: I left the |
docs/extended_api/asynchronous_operations_library/memcpy_async.md
Outdated
Show resolved
Hide resolved
8d29c49
to
4ebc664
Compare
Given that memcpy_async is supposed to be a replacement for assigning from global memory to shared memory ( #53 (comment) ) the statement |
@hcedwar thanks, that's good feedback, but can you contribute to the long comment thread above? Thanks! |
docs/extended_api/synchronization_library/pipeline_consumer_wait_prior.md
Outdated
Show resolved
Hide resolved
docs/extended_api/synchronization_library/pipeline_consumer_wait_prior.md
Outdated
Show resolved
Hide resolved
4ebc664
to
a6270ae
Compare
Thanks for the review @griwes, I addressed most of your comments and replied to a couple of others for clarification. The PR / preview now reflects those changes. |
@hcedwar: I do not think that this is the role of this document to specify in which cases the implementation actually exhibits asynchronous behavior, especially since it varies depending on the architecture. In my opinion, this information belongs to one of our other guides (programming guide, best practices guide, architecture-specific tuning guide). |
a6270ae
to
9e8c391
Compare
docs/extended_api/asynchronous_operations_library/memcpy_async.md
Outdated
Show resolved
Hide resolved
21a9af0
to
ad485ef
Compare
ad485ef
to
6a69a77
Compare
Thank you @c0riolis for doing all this work, the new docs look great! |
Group
concept &aligned_size_t