-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM container numcodecs fix #174
ARM container numcodecs fix #174
Conversation
/blossom-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good overall. But maybe we should think about how we can make Dockerfile changes like this and test container builds it in an environment that mimics an end user's and doesn't have all these custom wheels available.
Thanks @akshaysubr , you are right. I have done such testing for this and the previous PR. i.e. these builds work, even when these pre-built wheels are not available as it just reverts to source build in that case. The motivation to add these checks for pre-built wheels was to speed up internal builds. We need to do them nightly and having things build from source every time slows things down. That being said, you brought up an interesting point. I have been discussing this with @NickGeneva recently. We need to have a robust source build instructions that mimic the docker build behavior. A lot of projects have a third_party folder to track such dependencies and we should consider adding such to Modulus. Prepared this issue to track this further: #176 |
/blossom-ci |
Modulus Pull Request
Description
Workaround fix for #175
Checklist
Dependencies