Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Diffusion example for Kármán vortex street dataset #619

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

frijjoasis
Copy link

@frijjoasis frijjoasis commented Jul 24, 2024

Modulus Pull Request

Description

Add "A diffusion model for a 2d Kármán vortex street about a fixed cylinder" example

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

denoising_diffusion_pytorch
ema_pytorch

Signed-off-by: Edmund Ross <45109609+frijjoasis@users.noreply.github.com>
Signed-off-by: Edmund Ross <45109609+frijjoasis@users.noreply.github.com>
Signed-off-by: Edmund Ross <45109609+frijjoasis@users.noreply.github.com>
@mnabian mnabian self-requested a review July 25, 2024 01:50
@ktangsali ktangsali self-requested a review July 25, 2024 22:19
@NickGeneva NickGeneva added the external Issues/PR filed by people outside the team label Aug 20, 2024
@mnabian
Copy link
Collaborator

mnabian commented Oct 17, 2024

Hi @frijjoasis , thank you for your contribution! I have a few questions about this PR:

  • In there a paper corresponding to this model?
  • Is this code taken from another repo? If so, could you please provide the link?
  • Can the license be changed to Apache 2.0?

@frijjoasis
Copy link
Author

Hi, thanks for reviewing.

* In there a paper corresponding to this model?

Yes, it will be uploaded to ArXiv soon.

* Is this code taken from another repo? If so, could you please provide the link?

No, this is the only copy of the code available online. The idea as discussed with one of your team is to link this repo in the paper. The dataset will also be available elsewhere publicly online, and when it is I will update the training script here to download it.

* Can the license be changed to Apache 2.0?

Yes, I'll do that shortly.

Signed-off-by: Edmund Ross <45109609+frijjoasis@users.noreply.github.com>
@frijjoasis
Copy link
Author

Hi, apologies for the delay on this. The paper is now live here: https://arxiv.org/abs/2411.16417

The most recent commit modifies the license and includes a script to download, extract and post-process the dataset from Zenodo https://zenodo.org/records/13820259.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues/PR filed by people outside the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants