-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDA_VERSION instead of __CUDACC_VER_{MAJOR,MINOR}__? #38
Comments
NVCC's version variables are conveniently available during compilation, but the version is also needed at the shell level to build deb packages. I suspect this use case is what led to the current mechanism. An alternative might be to derive the version from the output |
Sorry, I missed this issue. Nathan is right regarding the initial reason behind the CUDA version detection. I agree we could support your case, where CUDA is already in the PATH and therefore you don't need to set CUDA_HOME. The new Makefile was supposed to be easier to integrate in any build environment (mostly all variables can be redefined) but maybe we have a regression on that aspect. Would it be an acceptable solution for you to set CUDA_HOME ? If there is no easier/cleaner way, I guess you can always set CUDA_HOME with :
|
Cleaning up old bugs. Please reopen if it is still a problem. Thanks ! |
Summary: See title. Differential Revision: D51420806
Summary: See title. Differential Revision: D51420806
Summary: See title. Differential Revision: D51420806
Summary: See title. Differential Revision: D51420806
Summary: Pull Request resolved: facebookresearch#38 See title. Reviewed By: wesbland Differential Revision: D51420806 fbshipit-source-id: e335d83175748fe7392c73881651bb9ad500a729
Just out of curiosity, is there a reason we infer CUDA_VERSION out of libcudart.so, instead of CUDACC_VER_MAJOR and CUDACC_VER_MINOR defined by nvcc? I am curious mainly because having CUDA_VERSION figured out via shell script makes it kind of hard to compile in a separate environment without manually feeding in these macros.
The text was updated successfully, but these errors were encountered: