-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows + Visual Studio port #31
base: master
Are you sure you want to change the base?
Conversation
…e converted to C++11 in the process. Unsupported features in Windows: * CUDA IPC memory (and thus MPI applications) * NVML set processor affinity functionality Incomplete/untested features: * shmOpen/Unlink/Unmap
Hi @tbennun , Could you update your repository to the latest version of the official repo? |
Sure, I'll try to do it over the weekend. |
Conflicts: src/core.cu src/core.h src/libwrap.cu src/nccl.h
@happynear Done, tested on Windows. Please make sure everything still works prior to the merge, I didn't get a chance to test this on a Linux machine. |
Thanks:) |
Thanks for this contribution! I met a problem when compiling using VS2013 and CUDA 8.0, reads below: |
@pipipopo I'm using VS2015 and don't observe this error. The error seems to stem from src/common_coll.h, line 111. Try to play with the casting there (reinterpret_cast?) until it compiles. |
Great work! works great using VS2015. The only suggestion that I would have is to add a VERSION resource to the project so as to better track versioning info with the master project. |
Summary: Pull Request resolved: facebookresearch#31 Reviewed By: cenzhaometa Differential Revision: D50063012 Pulled By: kingchc fbshipit-source-id: 9b64bee4639f3fd58764b953cd6d8f8274565af6
Here is my attempt to port nccl to Windows.
In the process, some concepts (e.g., atomic variables) were converted to C++11.
Unsupported features in Windows:
Untested features: