Some minor fixes for compile/usage #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Jia-kai, Thanks for the fixes ! |
minsii
added a commit
to minsii/nccl
that referenced
this pull request
Feb 22, 2024
Summary: Pull Request resolved: facebookresearch#41 Differential Revision: D54004780
minsii
added a commit
to minsii/nccl
that referenced
this pull request
Mar 14, 2024
Summary: Pull Request resolved: facebookresearch#41 Reviewed By: YulunW Differential Revision: D54004780 fbshipit-source-id: 41627e6eafa14411c3d4dfdb83374622b08fca4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor modifications are included in this PR:
-lrttoLDFLAGS.shm_openneeds this flag, and it seems that nvcc automatically adds it; however, if one wants to linklibnccl.somanually with other projects usingld, it would fail due to undefined symbol.devlistparam inncclCommInitAllfromint*toconst int*, since it would not be modified and the user might actually pass aconst intpointer.