Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto build docs #53

Merged
merged 31 commits into from
Oct 21, 2024
Merged

Auto build docs #53

merged 31 commits into from
Oct 21, 2024

Conversation

brainwavecoder9
Copy link
Contributor

@brainwavecoder9 brainwavecoder9 commented Oct 12, 2024

SUMMARY

A number of changes to improve and automate the documentation build, and a little cleanup.

EXPLANATION

When trying to run make to build the README for #51 I ended up down a rabbit hole trying to get my build environment to be consistent (as did someone else in #24). Even after what I thought was a successful run, I still ended up with a slightly different format, which can make a very minor change seem quite complicated. Although there are a number of changes to this README, these are expected to be normalized through the new process so future changes are expected to be consistent.

This modification to the documentation creation process automates the build process in an isolated environment for creating the README file.

Additionally, a few other small changes were made to cleanup the repo and related process. A summary of all changes is below.

DESCRIPTION OF CHANGES

.github/workflows/generate-documentation.yml

  • New file enables the README make process to run within a GitHub Action. This defines dependencies and ensures consistency for the process, means anyone modifying documentation does not have to configure a local environment, and automates the process so that the make command never needs to be run manually. This will automatically run to create and commit the README, but only after a commit is made to the docs folder.

.gitattributes

  • modified to use lf line endings for MD files, nice for consistency generally, and required for local build process.

docs/Makefile has a number of changes:

  • upgraded syntax for 3.x pandoc to address deprecation [WARNING]
  • _markdown section updated to only execute python scripts. a bit cleaner than blindly attempting to execute text files
  • PYTHONPATH set to fix issue where chain_server was not available

docs/0_2_999_footer.md

  • removed an empty file that is not referenced, probably left over from changes made by Ryan Kraus in June (4477e66 & bd71c95)

docs/0_1_personal_key.md

docs/3.2_docs.md

  • Remove reference to make, added additional clarifying info, and let users know that the process will happen automatically

.static/*

  • A number of files automatically updated as part of the build process, referenced by the README

@brainwavecoder9
Copy link
Contributor Author

FYI @AmeliaYe

Happy to have a discussion here about any questions, or additional changes/updates that you might want related to this

@brainwavecoder9 brainwavecoder9 changed the title Auto build docs Auto build README Oct 14, 2024
@brainwavecoder9 brainwavecoder9 changed the title Auto build README Auto build docs Oct 14, 2024
@AmeliaYe AmeliaYe self-requested a review October 15, 2024 19:44
Copy link
Collaborator

@AmeliaYe AmeliaYe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the in-line comments everything including the README seems good to me

.github/workflows/generate-documentation.yml Outdated Show resolved Hide resolved
docs/Makefile Show resolved Hide resolved
@brainwavecoder9
Copy link
Contributor Author

FYI @AmeliaYe comments have been resolved.

  • implemented requirements change per request
  • added clarification re: concern about change affecting functionality for script execution

@AmeliaYe AmeliaYe merged commit 3daaa5e into NVIDIA:main Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants