-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto build docs #53
Merged
Merged
Auto build docs #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anywhere into auto-build-docs
…anywhere into auto-build-docs
… instructions wrapped into workflow
FYI @AmeliaYe Happy to have a discussion here about any questions, or additional changes/updates that you might want related to this |
…anywhere into auto-build-docs
AmeliaYe
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the in-line comments everything including the README seems good to me
FYI @AmeliaYe comments have been resolved.
|
AmeliaYe
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
A number of changes to improve and automate the documentation build, and a little cleanup.
EXPLANATION
When trying to run
make
to build the README for #51 I ended up down a rabbit hole trying to get my build environment to be consistent (as did someone else in #24). Even after what I thought was a successful run, I still ended up with a slightly different format, which can make a very minor change seem quite complicated. Although there are a number of changes to this README, these are expected to be normalized through the new process so future changes are expected to be consistent.This modification to the documentation creation process automates the build process in an isolated environment for creating the README file.
Additionally, a few other small changes were made to cleanup the repo and related process. A summary of all changes is below.
DESCRIPTION OF CHANGES
.github/workflows/generate-documentation.yml
make
process to run within a GitHub Action. This defines dependencies and ensures consistency for the process, means anyone modifying documentation does not have to configure a local environment, and automates the process so that the make command never needs to be run manually. This will automatically run to create and commit the README, but only after a commit is made to the docs folder..gitattributes
docs/Makefile
has a number of changes:docs/0_2_999_footer.md
docs/0_1_personal_key.md
docs/3.2_docs.md
make
, added additional clarifying info, and let users know that the process will happen automatically.static/*