Skip to content

Commit

Permalink
Set default CDI spec permissions to 644
Browse files Browse the repository at this point in the history
Although the nvidia-ctk cdi generate command generates
specs with 644 permissions, the nvidia-ctk cdi transform
commands do not. This change sets the default permissions
to 600 instead of 644.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
  • Loading branch information
elezar committed Jun 10, 2024
1 parent 221be30 commit 4babae3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* Use : as a config --set list separator. This fixes a bug in modifying lists in the config file with the `nvidia-ctk config` command.
* Add `RUNTIME_CONFIG_OVERRIDE` (`--runtime-config-override`) to the `nvidia-ctk runtime configure` command and the toolkit container to allow for containerd runtime options to be set directly. This can be used to override the `SystemdCroup` option explicitly, for example.
* Ensure consistent construction of libraries for CDI spec generation.
* Ensure that `nvidia-ctk cdi transform` creates specs with world-readable permissions.

## v1.15.0

Expand Down
2 changes: 1 addition & 1 deletion pkg/nvcdi/spec/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func newBuilder(opts ...Option) *builder {
s.format = FormatYAML
}
if s.permissions == 0 {
s.permissions = 0600
s.permissions = 0644
}
return s
}
Expand Down

0 comments on commit 4babae3

Please sign in to comment.