Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare changes for v1.15.1 release #495

Closed
wants to merge 11 commits into from

Conversation

@elezar elezar self-assigned this May 13, 2024
@elezar elezar force-pushed the cherry-pick-1.15.1 branch from a72c8c1 to 1cf0e95 Compare May 13, 2024 11:52
@elezar elezar force-pushed the cherry-pick-1.15.1 branch from bd80669 to f500b2d Compare May 21, 2024 10:11
@elezar elezar force-pushed the cherry-pick-1.15.1 branch from f500b2d to 221be30 Compare May 28, 2024 10:43
@elezar elezar force-pushed the cherry-pick-1.15.1 branch from 9c0f7d8 to be516e9 Compare July 1, 2024 14:31
elezar added 10 commits July 1, 2024 16:56
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This allows settings such as:

nvidia-ctk config --set nvidia-container-runtime.runtimes=crun:runc

to be applied correctly.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This allow for options such as SystemdCgroup to be optionally set.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change ensures that nvnllib and devicelib are constructed
before these are used to construct infolib.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Although the nvidia-ctk cdi generate command generates
specs with 644 permissions, the nvidia-ctk cdi transform
commands do not. This change sets the default permissions
to 600 instead of 644.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Tools such as oc mirror do not support the provenence metadata
added to the image manifests with newer docker buildx versions.

This change disables the addition of provenance information.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change moves most of the logging for the NVIDIA Container runtime
from Info to Debug or Trace -- especially in the case where no
modifications are requried.

This removes execessive logging.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the cherry-pick-1.15.1 branch from be516e9 to ce13289 Compare July 1, 2024 14:56
@elezar elezar marked this pull request as ready for review July 2, 2024 14:11
@elezar elezar requested review from klueska and cdesiniotis July 2, 2024 14:12
This change updates the logic to populate the options for the
nvidia runtime configs added to containerd or crio from a default runtime
if this is specified and a runc entry is not found.

This allows the default runtime values for settings such as SystemdCgroup
to be applied correctly.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the cherry-pick-1.15.1 branch from 6c991c9 to d4969fd Compare July 9, 2024 11:39
@elezar
Copy link
Member Author

elezar commented Aug 22, 2024

Closing since v1.16.x has been released.

@elezar elezar closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant