Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

Add CUDNN 3 and 4 to the CUDA 7.0 images. #21

Closed
wants to merge 3 commits into from

Conversation

elezar
Copy link
Member

@elezar elezar commented Dec 11, 2015

I have added Docker files for CUDNN 3 and 4 to the CUDA 7.0 images.

From the release notes, it seems as if CUDA 7.0 is the minimum requirements, and I run on a server where I am able to use Docker, but the drivers are not up to date for use with CUDA 7.5. I do, however, need CUDNN 3 (at least) for use with Caffe.

As a side note, there does seem to be quite a bit of duplication in the Docker files. Is there generation automated in some way?

@flx42
Copy link
Member

flx42 commented Dec 11, 2015

Thank you for the PR!
To accept your contribution, we need you to sign our CLA, see here:
https://github.com/nvidia/nvidia-docker#issues-and-contributing

887838d looks good, but I'm in the process of modifying how we fetch cudnn v4. You will probably need to amend your commit after I'm done. cudnn v3 will not change.
026a2f7 looks fine.
a48765c I disagree, you don't need to put tabs everywhere in a Makefile. Only before commands.

Regarding your question of duplication in Dockerfiles: no we don't have automated generation. Maybe we will in the future, but right now there are still a few differences between versions.

@flx42
Copy link
Member

flx42 commented Dec 11, 2015

I added 7.0 cudnn4 myself, since I was asked to do a Caffe image. I will still take your first 2 patches for 7.0 cudnn3 + the custom docker executable. I will rebase your code myself, just send us the CLA!

@elezar
Copy link
Member Author

elezar commented Dec 12, 2015

Great! With regards to the tabs in a48765c, I know that tabs are only required for the commands. The spacing where the cudnn versions were specified, was just inconsistent (mixed tabs and spaces). I can use spaces instead if that would be better.

I have just emailed the CLA and CCed you, @flx42.

@flx42 flx42 closed this in c42f955 Dec 14, 2015
flx42 pushed a commit that referenced this pull request Dec 14, 2015
Closes: #21
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
@flx42
Copy link
Member

flx42 commented Dec 14, 2015

Merged, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants