Add gitignore file #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix a typo in README - remove extra files - add gitignore file Signed-off-by: Allen Xu <allxu@nvidia.com>
zhanga5
reviewed
Sep 28, 2021
| */metastore_db | ||
| */spark-warehouse | ||
| */.vscode | ||
| */.clang-format |
GaryShen2008
approved these changes
Sep 28, 2021
zhanga5
reviewed
Sep 28, 2021
| @@ -53,7 +53,7 @@ val pca = new com.nvidia.spark.ml.feature.PCA() | |||
| $ make install # install the library librmm.so to '/install/path' | |||
| ``` | |||
| 5. [RAFT](https://github.com/rapidsai/raft): | |||
| - raft provides only header files, so not build instructions for it. | |||
There was a problem hiding this comment.
noticed only PCA was mentioned in this readme. Does it mean only this algorithm is supported or include all others from original apache package?
from line #24, does it mean all existing functions are supported? Is there any potential compatibility issue?
We used a customized class and add some extra API switches:
...
There was a problem hiding this comment.
Good catch. Now only PCA is supported now. I will update this confusing part.
wjxiz1992
added a commit
that referenced
this pull request
Oct 8, 2021
* Init signoff check (#1) Signed-off-by: Peixin Li <pxli@nyu.edu> * Add gitignore file (#4) - fix a typo in README - remove extra files - add gitignore file Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Allen Xu <allxu@nvidia.com> * Change maven resource plugin version (#5) - to build successfully in docker Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Allen Xu <allxu@nvidia.com> * Update README about API usage (#6) * Update README about API usage Signed-off-by: Allen Xu <allxu@nvidia.com> * typo Co-authored-by: Allen Xu <allxu@nvidia.com> * Update version (#7) * Update version * Add Sign-off Signed-off-by: Allen Xu <allxu@nvidia.com> * Update version Signed-off-by: Allen Xu <allxu@nvidia.com> * specify library version Co-authored-by: Allen Xu <allxu@nvidia.com> * Add developer and SCM items in project's pom.xml for the public release (#10) Signed-off-by: Tim Liu <timl@nvidia.com> * Update version for release Signed-off-by: Allen Xu <allxu@nvidia.com> * Add example link Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Peixin <pxli@nyu.edu> Co-authored-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com>
wjxiz1992
added a commit
that referenced
this pull request
Oct 11, 2021
* Merge 21.10-branch to main for 21.10 release (#13) * Init signoff check (#1) Signed-off-by: Peixin Li <pxli@nyu.edu> * Add gitignore file (#4) - fix a typo in README - remove extra files - add gitignore file Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Allen Xu <allxu@nvidia.com> * Change maven resource plugin version (#5) - to build successfully in docker Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Allen Xu <allxu@nvidia.com> * Update README about API usage (#6) * Update README about API usage Signed-off-by: Allen Xu <allxu@nvidia.com> * typo Co-authored-by: Allen Xu <allxu@nvidia.com> * Update version (#7) * Update version * Add Sign-off Signed-off-by: Allen Xu <allxu@nvidia.com> * Update version Signed-off-by: Allen Xu <allxu@nvidia.com> * specify library version Co-authored-by: Allen Xu <allxu@nvidia.com> * Add developer and SCM items in project's pom.xml for the public release (#10) Signed-off-by: Tim Liu <timl@nvidia.com> * Update version for release Signed-off-by: Allen Xu <allxu@nvidia.com> * Add example link Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Peixin <pxli@nyu.edu> Co-authored-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com> * Update version * update Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Peixin <pxli@nyu.edu> Co-authored-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com>
leewyang
pushed a commit
to leewyang/spark-rapids-ml
that referenced
this pull request
Feb 23, 2023
- fix a typo in README - remove extra files - add gitignore file Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Allen Xu <allxu@nvidia.com>
leewyang
pushed a commit
to leewyang/spark-rapids-ml
that referenced
this pull request
Feb 23, 2023
* Merge 21.10-branch to main for 21.10 release (NVIDIA#13) * Init signoff check (NVIDIA#1) Signed-off-by: Peixin Li <pxli@nyu.edu> * Add gitignore file (NVIDIA#4) - fix a typo in README - remove extra files - add gitignore file Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Allen Xu <allxu@nvidia.com> * Change maven resource plugin version (NVIDIA#5) - to build successfully in docker Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Allen Xu <allxu@nvidia.com> * Update README about API usage (NVIDIA#6) * Update README about API usage Signed-off-by: Allen Xu <allxu@nvidia.com> * typo Co-authored-by: Allen Xu <allxu@nvidia.com> * Update version (NVIDIA#7) * Update version * Add Sign-off Signed-off-by: Allen Xu <allxu@nvidia.com> * Update version Signed-off-by: Allen Xu <allxu@nvidia.com> * specify library version Co-authored-by: Allen Xu <allxu@nvidia.com> * Add developer and SCM items in project's pom.xml for the public release (NVIDIA#10) Signed-off-by: Tim Liu <timl@nvidia.com> * Update version for release Signed-off-by: Allen Xu <allxu@nvidia.com> * Add example link Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Peixin <pxli@nyu.edu> Co-authored-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com> * Update version * update Signed-off-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Peixin <pxli@nyu.edu> Co-authored-by: Allen Xu <allxu@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Xu allxu@nvidia.com