[FEA] Add ANSI support #5120
Labels
audit_4.0.0
Audit related tasks for 4.0.0
epic
Issue that encompasses a significant feature or body of work
feature request
New feature or request
Comments
nartal1
added
feature request
|
Note: integrate test framework currently explicitly sets ANSI mode to off for each test, so we need to change this to test with ANSI mode on. |
mythrocks
added a commit
to mythrocks/spark-rapids
that referenced
this issue
Jun 17, 2024
Fixes NVIDIA#11019. Window function tests fail on Spark 4.0 because of NVIDIA#5114 (and NVIDIA#5120 broadly), because spark-rapids does not support SUM, COUNT, and certain other aggregations in ANSI mode. This commit disables ANSI mode tests for the failing window function tests. These may be revisited, once error/overflow checking is available for ANSI mode in spark-rapids. Signed-off-by: MithunR <mithunr@nvidia.com>
razajafri
pushed a commit
that referenced
this issue
Jun 26, 2024
* Disable ANSI mode for window function tests. Fixes #11019. Window function tests fail on Spark 4.0 because of #5114 (and #5120 broadly), because spark-rapids does not support SUM, COUNT, and certain other aggregations in ANSI mode. This commit disables ANSI mode tests for the failing window function tests. These may be revisited, once error/overflow checking is available for ANSI mode in spark-rapids. Signed-off-by: MithunR <mithunr@nvidia.com> * Switch from @ansi_mode_disabled to @disable_ansi_mode. --------- Signed-off-by: MithunR <mithunr@nvidia.com>
wjxiz1992
added a commit
to nvliyuan/yuali-spark-rapids
that referenced
this issue
Jun 26, 2024
* optimzing Expand+Aggregate in sqlw with many count distinct Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> * Add GpuBucketingUtils shim to Spark 4.0.0 (NVIDIA#11092) * Add GpuBucketingUtils shim to Spark 4.0.0 * Signing off Signed-off-by: Raza Jafri <rjafri@nvidia.com> --------- Signed-off-by: Raza Jafri <rjafri@nvidia.com> * Improve the diagnostics for 'conv' fallback explain (NVIDIA#11076) * Improve the diagnostics for 'conv' fallback explain Signed-off-by: Jihoon Son <ghoonson@gmail.com> * don't use nil Signed-off-by: Jihoon Son <ghoonson@gmail.com> * the bases should not be an empty string in the error message when the user input is not Signed-off-by: Jihoon Son <ghoonson@gmail.com> * more user-friendly message * Update sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala Co-authored-by: Gera Shegalov <gshegalov@nvidia.com> --------- Signed-off-by: Jihoon Son <ghoonson@gmail.com> Co-authored-by: Gera Shegalov <gshegalov@nvidia.com> * Disable ANSI mode for window function tests [databricks] (NVIDIA#11073) * Disable ANSI mode for window function tests. Fixes NVIDIA#11019. Window function tests fail on Spark 4.0 because of NVIDIA#5114 (and NVIDIA#5120 broadly), because spark-rapids does not support SUM, COUNT, and certain other aggregations in ANSI mode. This commit disables ANSI mode tests for the failing window function tests. These may be revisited, once error/overflow checking is available for ANSI mode in spark-rapids. Signed-off-by: MithunR <mithunr@nvidia.com> * Switch from @ansi_mode_disabled to @disable_ansi_mode. --------- Signed-off-by: MithunR <mithunr@nvidia.com> --------- Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> Signed-off-by: Raza Jafri <rjafri@nvidia.com> Signed-off-by: Jihoon Son <ghoonson@gmail.com> Signed-off-by: MithunR <mithunr@nvidia.com> Co-authored-by: Hongbin Ma (Mahone) <mahongbin@apache.org> Co-authored-by: Raza Jafri <razajafri@users.noreply.github.com> Co-authored-by: Jihoon Son <jihoonson@apache.org> Co-authored-by: Gera Shegalov <gshegalov@nvidia.com> Co-authored-by: MithunR <mithunr@nvidia.com>
SurajAralihalli
pushed a commit
to SurajAralihalli/spark-rapids
that referenced
this issue
Jul 12, 2024
* Disable ANSI mode for window function tests. Fixes NVIDIA#11019. Window function tests fail on Spark 4.0 because of NVIDIA#5114 (and NVIDIA#5120 broadly), because spark-rapids does not support SUM, COUNT, and certain other aggregations in ANSI mode. This commit disables ANSI mode tests for the failing window function tests. These may be revisited, once error/overflow checking is available for ANSI mode in spark-rapids. Signed-off-by: MithunR <mithunr@nvidia.com> * Switch from @ansi_mode_disabled to @disable_ansi_mode. --------- Signed-off-by: MithunR <mithunr@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We have ANSI support for some of the SQL functions/operators and casting but it is not completely in sync with everything that Spark supports. This epic is to list out the gaps and track the remaining issues.
Auditing ANSI issues based on Spark JIRA - https://issues.apache.org/jira/browse/SPARK-30374
P1 issues
approx_percentileforbyteinput #11198json_matrix_test.py::test_scan_json_stringfails on Spark 4 #11154approx_percentileforbyteinput #11198P2 issues
parse_url#11193Completed issues
mapKeyNotExistError#5295The text was updated successfully, but these errors were encountered: