Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] combine window operations into single call #866

Closed
revans2 opened this issue Sep 28, 2020 · 0 comments · Fixed by #2882
Closed

[FEA] combine window operations into single call #866

revans2 opened this issue Sep 28, 2020 · 0 comments · Fixed by #2882
Labels
feature request New feature or request P1 Nice to have for release performance A performance related task/issue
Milestone
July 19 - July 30

Comments

@revans2
Copy link
Collaborator

revans2 commented Sep 28, 2020

Is your feature request related to a problem? Please describe.
The current GpuWindowExec acts a lot like a Project. Each window operation is done separately from all of the others. This is fine for now and reflects the underlying window implementation in cudf where each window call is does independently of the others. IT would be good if we could look at combining the window calls together more like hash aggregate so that we could combine some of the overhead associated with each call.

This will require changes to cudf to get any real benefit from it.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify performance A performance related task/issue labels Sep 28, 2020
@sameerz sameerz added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Sep 29, 2020
@revans2 revans2 added this to the July 19 - July 30 milestone Jul 26, 2021
@revans2 revans2 linked a pull request Jul 26, 2021 that will close this issue
Refactor window operations to do them in the exec #2882
Merged
@revans2 revans2 closed this as completed Jul 26, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 7c30e051dc22fc393b746a4ae5d538871035a52c (NV…
b38dadb 
…IDIA#866)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request P1 Nice to have for release performance A performance related task/issue
Projects
None yet
Milestone
July 19 - July 30
Development

Successfully merging a pull request may close this issue.

Refactor window operations to do them in the exec revans2/spark-rapids
2 participants
@revans2 @sameerz