Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in config to avoid AST in some join cases #10553

Closed
wants to merge 1 commit into from
Closed

Add in config to avoid AST in some join cases #10553

wants to merge 1 commit into from

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Mar 5, 2024

This is intended to be a test to see if it will improve the performance in some cases so we can possibly come up with a heuristic in the future.

@revans2
Add in config to avoid AST in some join cases
1c69f1f 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2
Copy link
Collaborator Author

revans2 commented Mar 5, 2024

build

jlowe
jlowe reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have RapidsMeta have the ability for expressions to be disabled for AST individually if spark.rapids.sql.expression.ast.classname is false? We probably still want an overall AST join enable as implemented here.

@revans2
Copy link
Collaborator Author

revans2 commented Mar 6, 2024

Would it make sense to have RapidsMeta have the ability for expressions to be disabled for AST individually if spark.rapids.sql.expression.ast.classname is false? We probably still want an overall AST join enable as implemented here.

Possibly. I'm not sure that we ever want to actually merge this in. It is here as a tool for now to see if a specific query would get faster or slower with it.

@sameerz sameerz added the performance A performance related task/issue label Mar 6, 2024
@revans2 revans2 changed the base branch from branch-24.04 to branch-24.06 April 10, 2024 17:54
@revans2 revans2 changed the base branch from branch-24.06 to branch-24.10 July 30, 2024 18:16
@revans2
Copy link
Collaborator Author

revans2 commented Oct 9, 2024

Closing for now. We can open this again if we need to.

@revans2 revans2 closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe left review comments

Assignees
No one assigned
Labels
performance A performance related task/issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@revans2 @jlowe @sameerz