-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UT adjust override checkScanSchemata & enabling ut of exclude_by_suffix fea. #11520
Merged
Feng-Jiang28
merged 6 commits into
NVIDIA:branch-24.12
from
Feng-Jiang28:SchemaPruningSuiteUTAdjust
Oct 25, 2024
Merged
UT adjust override checkScanSchemata & enabling ut of exclude_by_suffix fea. #11520
Feng-Jiang28
merged 6 commits into
NVIDIA:branch-24.12
from
Feng-Jiang28:SchemaPruningSuiteUTAdjust
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fejiang <fejiang@nvidia.com>
Feng-Jiang28
added
? - Needs Triage
Need team to review and classify
and removed
? - Needs Triage
Need team to review and classify
labels
Sep 27, 2024
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
build |
Feng-Jiang28
changed the title
UT adjust override checkScanScehmata. (WIP)
UT adjust override checkScanScehmata.
Oct 24, 2024
Feng-Jiang28
requested review from
thirtiseven and
binmahone
and removed request for
thirtiseven
October 24, 2024 07:36
Signed-off-by: fejiang <fejiang@nvidia.com>
build |
Feng-Jiang28
changed the title
UT adjust override checkScanScehmata.
UT adjust override checkScanScehmata & enabling ut of exclude_by_suffix fea.
Oct 24, 2024
Feng-Jiang28
changed the title
UT adjust override checkScanScehmata & enabling ut of exclude_by_suffix fea.
UT adjust override checkScanSchemata & enabling ut of exclude_by_suffix fea.
Oct 25, 2024
thirtiseven
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark UT framework enabled RapidsParquetSchemaPruningSuite, #11366, however, most of the testcases failed becuase of test framework issue, this pr is for adjust the test framework by rewritting checkScanSchemata.