Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT adjust override checkScanSchemata & enabling ut of exclude_by_suffix fea. #11520

Merged

Conversation

Feng-Jiang28
Copy link
Collaborator

@Feng-Jiang28 Feng-Jiang28 commented Sep 27, 2024

Spark UT framework enabled RapidsParquetSchemaPruningSuite, #11366, however, most of the testcases failed becuase of test framework issue, this pr is for adjust the test framework by rewritting checkScanSchemata.

Signed-off-by: fejiang <fejiang@nvidia.com>
@Feng-Jiang28 Feng-Jiang28 self-assigned this Sep 27, 2024
@Feng-Jiang28 Feng-Jiang28 added ? - Needs Triage Need team to review and classify and removed ? - Needs Triage Need team to review and classify labels Sep 27, 2024
@Feng-Jiang28 Feng-Jiang28 marked this pull request as draft September 27, 2024 08:14
@Feng-Jiang28 Feng-Jiang28 changed the base branch from branch-24.10 to branch-24.12 October 9, 2024 02:14
Signed-off-by: fejiang <fejiang@nvidia.com>
Signed-off-by: fejiang <fejiang@nvidia.com>
@Feng-Jiang28
Copy link
Collaborator Author

build

@Feng-Jiang28 Feng-Jiang28 marked this pull request as ready for review October 24, 2024 03:47
@Feng-Jiang28 Feng-Jiang28 changed the title UT adjust override checkScanScehmata. (WIP) UT adjust override checkScanScehmata. Oct 24, 2024
@Feng-Jiang28 Feng-Jiang28 requested review from thirtiseven and binmahone and removed request for thirtiseven October 24, 2024 07:36
Signed-off-by: fejiang <fejiang@nvidia.com>
@Feng-Jiang28
Copy link
Collaborator Author

build

Signed-off-by: fejiang <fejiang@nvidia.com>
@Feng-Jiang28 Feng-Jiang28 changed the title UT adjust override checkScanScehmata. UT adjust override checkScanScehmata & enabling ut of exclude_by_suffix fea. Oct 24, 2024
@Feng-Jiang28 Feng-Jiang28 changed the title UT adjust override checkScanScehmata & enabling ut of exclude_by_suffix fea. UT adjust override checkScanSchemata & enabling ut of exclude_by_suffix fea. Oct 25, 2024
Copy link
Collaborator

@thirtiseven thirtiseven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Feng-Jiang28 Feng-Jiang28 merged commit 910b64d into NVIDIA:branch-24.12 Oct 25, 2024
47 checks passed
@sameerz sameerz added the test Only impacts tests label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants