Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test case related to LEACY datetime format to unblock nightly CI #11544

Open
wants to merge 2 commits into
base: branch-24.12
Choose a base branch
from

Conversation

res-life
Copy link
Collaborator

@res-life res-life commented Sep 30, 2024

Closes #11539

Changes

Update test case: Only test years after 1900

Description

This issue is related to LEGACY mode, Spark itself has different behaviors between LEGACY mode and non-LEGACY mode, and Rapids kernel has not 100% matched non-LEGACY yet.
Rapids keeps consistent with Spark when mode is CORRECTED mode.

We already documented that LEGACY mode has several limitations

So only update test case.

Signed-off-by: Chong Gao res_life@163.com

Signed-off-by: Chong Gao <res_life@163.com>
@res-life
Copy link
Collaborator Author

build

@res-life
Copy link
Collaborator Author

Do we need to update the 24.10 branch? @pxLi

@pxLi
Copy link
Collaborator

pxLi commented Sep 30, 2024

Do we need to update the 24.10 branch? @pxLi

yes, this is blocking 24.10 interminttently

@pxLi pxLi added the test Only impacts tests label Sep 30, 2024
@res-life res-life changed the title Disable a case related to LEACY datetime format to unblock nightly CI Update test case related to LEACY datetime format to unblock nightly CI Sep 30, 2024
@pxLi
Copy link
Collaborator

pxLi commented Sep 30, 2024

can you retarget to 24.10? thanks

@res-life
Copy link
Collaborator Author

can you retarget to 24.10? thanks

This PR is fixing 24.10.

@res-life
Copy link
Collaborator Author

build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants