Fix the build error for Spark 400 #11905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
res-life
reviewed
Dec 25, 2024
| funcs: Seq[ChainedPythonFunctions], | ||
| evalType: Int, | ||
| argOffsets: Array[Array[Int]], | ||
| jobArtifactUUID: Option[String] |
There was a problem hiding this comment.
Add a default Parameters for calss GpuBasePythonRunner?
Then user can pass in the map.
like:
abstract class GpuBasePythonRunner[IN](
funcs: Seq[ChainedPythonFunctions],
evalType: Int,
argOffsets: Array[Array[Int]],
jobArtifactUUID: Option[String],
cfg: Map[String, String] = Map.empty
) extends BasePythonRunner[IN, ColumnarBatch](funcs, evalType, argOffsets, jobArtifactUUID,
cfg)There was a problem hiding this comment.
We need to change this for all the shims if the signature changes, so for a quick fix, an empty map should be good enough for now.
We will do as your suggestion in following PRs if this becomes a necessary parameter for GPU.
res-life
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11895
Spark 400 introduces a new parameter in BasePythonRunner, so this PR creates a new shim for this change and specifies this to an empty map to pass the build. It is ok since this metric parameter is only for debugging.