Add option to disable measuring buffer copy #11996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ray Liu <liurenjie2008@gmail.com>
Signed-off-by: Ray Liu <liurenjie2008@gmail.com>
liurenjie1024
force-pushed
the
ray/option_to_disable_buffer_copy
branch
from
6bdaa67 to
5a27ca3
Compare
Signed-off-by: Ray Liu <liurenjie2008@gmail.com>
Signed-off-by: Ray Liu <liurenjie2008@gmail.com>
|
build |
winningsix
reviewed
Jan 24, 2025
| @@ -2025,6 +2025,15 @@ val SHUFFLE_COMPRESSION_LZ4_CHUNK_SIZE = conf("spark.rapids.shuffle.compression. | |||
| .booleanConf | |||
| .createWithDefault(false) | |||
|
|
|||
| val SHUFFLE_KUDO_SERIALIZER_MEASURE_BUFFER_COPY_ENABLED = | |||
There was a problem hiding this comment.
Is there any case we still need measuring buffer on for kudo? If not, should consider removing it.
There was a problem hiding this comment.
I want to keep it to do some experiments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of #11995 .
It adds an option to disable measuring copy buffer time in spark-rapids. It doesn't actually disable it for kudo serializer, but could hide metrics.