support interval.microseconds for range window TimeStampType #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. This change supports interval.microseconds for TimeStampType. 2.fix a range window on DateType bug. When the order-by column type is DateType, the value bounded type should be IntegerType instead of CalendarIntervalType. In other words, Interval is not working when order-by column is DateType. Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
revans2
reviewed
May 27, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuWindowExpression.scala
Outdated
Show resolved
Hide resolved
|
build |
wbo4958
changed the title
wbo4958
changed the title
wbo4958
changed the title
revans2
reviewed
May 28, 2021
| ci.microseconds) | ||
| } catch { | ||
| case e: ArithmeticException => | ||
| willNotWorkOnGpu("interval total microseconds has overflow") |
There was a problem hiding this comment.
I would like to see a better message. It is not clear how the user can fix this or what exactly has happened.
Perhaps something more like
willNotWorkOnGpu(s"windows over timestamps are converted to microseconds and $ci is too large to fit")
There was a problem hiding this comment.
Thx @revans2. Done
|
build |
revans2
approved these changes
Jun 1, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…2525) Signed-off-by: Bobby Wang <wbo4958@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…2525) Signed-off-by: Bobby Wang <wbo4958@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.fix a range window on DateType bug.
When the order-by column type is DateType, the value bounded type
should be IntegerType instead of CalendarIntervalType.
In other words, Interval is not working when order-by column is DateType.
Signed-off-by: Bobby Wang wbo4958@gmail.com