Add in support for arrays in BroadcastNestedLoopJoinExec and CartesianProductExec #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
revans2
added
SQL
|
build |
revans2
changed the title
abellina
added a commit
to abellina/spark-rapids
that referenced
this pull request
Jun 18, 2021
This reverts commit 44a48ca. Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
added a commit
that referenced
this pull request
Jun 21, 2021
abellina
added a commit
to abellina/spark-rapids
that referenced
this pull request
Jun 25, 2021
…NVIDIA#2749)" This reverts commit b3e7c4b.
mythrocks
added a commit
to mythrocks/spark-rapids
that referenced
this pull request
Jul 21, 2021
…NVIDIA#2749)" This reverts commit b3e7c4b. This re-enables support for lists in Broadcast Nested Loop Joins, and Cartesian joins, as was intended in 2702. Signed-off-by: Mithun RK <mythrocks@gmail.com>
mythrocks
added a commit
that referenced
this pull request
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the profiling tool with some large applications I noticed that it would do a few big joins using either
CartesianProductExecorBroadcastNestedLoopJoinExecwith an array and array_contains as the conditions. So I enabled it in the check wrote some tests, and this sped it up massively.