Fix cast to date bug #2890
Merged
Fix cast to date bug #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this a draft so it isn't inadvertently committed while #2875 is under review. |
jlowe
reviewed
Jul 8, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala
Outdated
Show resolved
Hide resolved
jlowe
previously approved these changes
Jul 9, 2021
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
fix-cast-to-date-bug
branch
from
675fa3c
to
01ba4ae
Compare
|
This is now rebased. |
jlowe
approved these changes
Jul 9, 2021
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #2875 and closes #2868
Commit # 4 adds the test and commit # 5 adds the fix.
There was a bug in the regex that sanitizes input for CAST string to date where it was removing trailing characters in some cases, converting invalid inputs into valid inputs.