Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzz tests for cast from string to other types #2898

Merged
merged 10 commits into from
Jul 13, 2021

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Jul 9, 2021

This PR adds tests for casting from string to other types using generated strings. Every test exposed at least one new bug and issues have been filed and are referenced from this PR.

I would like to merge this PR before fixing any of the bugs so that we can enable the relevant test as part of the bug fix PRs.

@andygrove andygrove changed the title WIP: Add fuzz tests for cast from string to other types Add fuzz tests for cast from string to other types Jul 9, 2021
@andygrove andygrove marked this pull request as ready for review July 9, 2021 19:49
@sameerz sameerz added the test Only impacts tests label Jul 9, 2021
@sameerz sameerz added this to the July 5 - July 16 milestone Jul 9, 2021
@andygrove andygrove self-assigned this Jul 9, 2021
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a comment on an ignored test but otherwise lgtm.

…w that the fix is merged

Signed-off-by: Andy Grove <andygrove@nvidia.com>
@jlowe
Copy link
Member

jlowe commented Jul 12, 2021

build

@andygrove andygrove merged commit 76c57f1 into NVIDIA:branch-21.08 Jul 13, 2021
@andygrove andygrove deleted the fuzzer-string branch July 13, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants