Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid struct aliasing in test_round_robin_sort_fallback #2986

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Avoid struct aliasing in test_round_robin_sort_fallback #2986

merged 1 commit into from
Jul 21, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Jul 21, 2021 •
edited
Loading

This fixes #2965 by adding yet another struct field to avoid aliasing with the top-level schema which is also a struct-with-long.

@jlowe
Avoid struct aliasing in test_round_robin_sort_fallback
c1bee42 
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the test Only impacts tests label Jul 21, 2021
@jlowe jlowe self-assigned this Jul 21, 2021
@jlowe
Copy link
Member Author

jlowe commented Jul 21, 2021

build

abellina
abellina approved these changes Jul 21, 2021
View reviewed changes
Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

If we can consider having a version of this test that is broken in the older Spark but works with newer versions that might be nice (with a is_before_spark_303() tag)

@jlowe jlowe merged commit 283d87c into NVIDIA:branch-21.08 Jul 21, 2021
@jlowe jlowe deleted the tweak-test-round-robin branch September 10, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abellina abellina abellina approved these changes

Assignees

@jlowe jlowe

Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] test_round_robin_sort_fallback failed with ValueError: 'a_1' is not in list
2 participants
@jlowe @abellina