-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable a smoke test for UCX in pre-merge #3200
Enable a smoke test for UCX in pre-merge #3200
Conversation
build |
3 similar comments
build |
build |
build |
This seems to mostly be working, but I am getting an issue in |
build |
2 similar comments
build |
build |
Waiting on: #3218 to be merged and image pushed. |
99c7e20
to
bea8ca4
Compare
build |
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
bea8ca4
to
ac5aec6
Compare
build |
build |
build |
Looks like the pattern matching does not work consistently in different shell envs, I don't know if we have better way to do replace in bash default_value syntax. At least we can trim first, then assign a default value |
I tested this with the command line, instead of within bash, so I was able to reproduce the issue locally. I got it to work with 2 statements, but was not able to with a single statement. |
build |
This PR runs
test_hash_grpby_sum
with UCX enabled, as UCX is now installed in the docker image.This adds ~1-2 minutes to the build from the logs. It starts the smoke test from the
mvn_verify
function so it could be merged without disturbing the jenkins file. Themvn_verify
and nowrapids_shuffle_smoke_test
assume spark 3.0.1 for the pre-merge build. There will be a follow on PR to clean up howrapids_shuffle_smoke_test
gets invoked, though right now I piggy back frommvn_verify
binaries.I added a variable so the correct shuffle manager shim can be picked up (
SHUFFLE_SPARK_SHIM
). This should be kept in sync withSPARK_VER
.There is a
local-cluster
issue I noted which happens even without the shuffle manager and will file a follow up, as it seems unrelated. I am inclined to let this use standalone mode for now. I could use some more eyes on it to see if it makes sense.Also I chose a simple test, it does use the UCX shuffle. I can enable others in case it's not going to change that 1-2 minute time addition too much, or pick something else. Just pick the first thing that I knew would use UCX.