Fix unreachable code warnings in GpuCast #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
|
premerge CI seemed to fail before it even started. Kicking again. |
|
build |
andygrove
approved these changes
Aug 13, 2021
Looks like git failed to fetch the merged PR from github, could be github inconsistent issue (data sync up delay) |
razajafri
pushed a commit
to razajafri/spark-rapids
that referenced
this pull request
Aug 23, 2021
Signed-off-by: Jason Lowe <jlowe@nvidia.com> Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3162 the build emits an unreachable code warning:
This removes a few of the match cases that will never be reached to resolve the build warning.