ArrayMax and ArrayMin support plus map_entries, map_keys, map_values #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
revans2
added
the
task
jlowe
reviewed
Aug 30, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuListUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
|
Moved this into draft because I am seeing some illegal memory access errors when running the tests in parallel, but not when running the tests one at a time. I need to spend some time debugging this. |
|
It looks like min and max on strings when doing a sorted aggregation can produce the IllegalMemoryAccess problem. I will try to reproduce it in cudf. |
|
build |
jlowe
reviewed
Sep 1, 2021
jlowe
approved these changes
Sep 1, 2021
sameerz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step at doing some array aggregations. It implements array_min and array_max. In the next step I hope to be able to do pattern matching on the higher order functions in aggregation and be able to implement a subset of it using a combination of
transformwhich is already implemented and some more generalized array aggregation code.