Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limitations for Databricks doc #3501

Merged
merged 10 commits into from
Sep 16, 2021
Merged

Add limitations for Databricks doc #3501

merged 10 commits into from
Sep 16, 2021

Conversation

viadea
Copy link
Collaborator

@viadea viadea commented Sep 15, 2021

Add limitations for databricks.

@viadea
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
af32363 
Add limitations for databricks.
@viadea viadea mentioned this pull request Sep 15, 2021
Closed
@viadea viadea added the documentation Improvements or additions to documentation label Sep 15, 2021
tgravescs
tgravescs reviewed Sep 15, 2021
View reviewed changes
docs/get-started/getting-started-databricks.md Outdated
@@ -155,3 +155,32 @@ storage location using Databricks [cluster log
delivery](https://docs.databricks.com/clusters/configure.html#cluster-log-delivery-1). Enable this
option before starting the cluster to capture the logs.

## Limitations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add something at the very beginning of the getting started on data bricks doc rather than here. We also have other text in here that mentioned AQE . Perhaps also put in FAQ. I think @jlowe had some other ideas.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this shouldn't be hidden at the end of the document. I also think the FAQ entry for DPP and the FAQ entry for AQE should be updated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlowe @tgravescs I just added lines to mention DPP/AQE is not supported on databricks in FAQ. How is now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the FAQ entries, but this section is still hidden at the end of the doc which was the original issue raised by this comment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlowe @sameerz I put limitation section to top. How do you think now?

@sameerz sameerz added this to the Sep 13 - Sep 24 milestone Sep 15, 2021
@jlowe jlowe changed the title Add limitations for databricks doc Add limitations for Databricks doc Sep 15, 2021
jlowe
jlowe reviewed Sep 15, 2021
View reviewed changes
docs/get-started/getting-started-databricks.md Outdated
@@ -155,3 +155,32 @@ storage location using Databricks [cluster log
delivery](https://docs.databricks.com/clusters/configure.html#cluster-log-delivery-1). Enable this
option before starting the cluster to capture the logs.

## Limitations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this shouldn't be hidden at the end of the document. I also think the FAQ entry for DPP and the FAQ entry for AQE should be updated.

docs/get-started/getting-started-databricks.md Outdated Show resolved Hide resolved
viadea and others added 4 commits September 15, 2021 15:33
@viadea @sameerz
Update docs/get-started/getting-started-databricks.md
ae8ae0b 
Add indentation

Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
@viadea
Update getting-started-databricks.md
67a1142 
updated
@viadea
Update getting-started-databricks.md
7e2f2e0
@viadea
Signed-off-by: Hao Zhu <hazhu@nvidia.com>
08e173a 
Add databricks limitation to FAQ
sameerz
sameerz requested changes Sep 16, 2021
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
docs/FAQ.md Outdated Show resolved Hide resolved
viadea and others added 2 commits September 15, 2021 18:35
@viadea @sameerz
Update docs/FAQ.md
28eff85 
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
@viadea @sameerz
Update docs/FAQ.md
f0f5c67 
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
jlowe
jlowe previously approved these changes Sep 16, 2021
View reviewed changes
docs/FAQ.md Show resolved Hide resolved
docs/FAQ.md Outdated Show resolved Hide resolved
docs/get-started/getting-started-databricks.md Outdated
@@ -155,3 +155,32 @@ storage location using Databricks [cluster log
delivery](https://docs.databricks.com/clusters/configure.html#cluster-log-delivery-1). Enable this
option before starting the cluster to capture the logs.

## Limitations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the FAQ entries, but this section is still hidden at the end of the doc which was the original issue raised by this comment.

docs/get-started/getting-started-databricks.md Outdated Show resolved Hide resolved
@jlowe jlowe dismissed their stale review September 16, 2021 13:31

Accidental approval

viadea and others added 3 commits September 16, 2021 08:41
@viadea @jlowe
Update docs/get-started/getting-started-databricks.md
4b7f3b8 
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@viadea
Update FAQ.md
0b5e20b
@viadea
Update getting-started-databricks.md
d8b5520 
Move limitations section to top.
@sameerz
Copy link
Collaborator

sameerz commented Sep 16, 2021

build

@sameerz sameerz merged commit 20057bc into NVIDIA:branch-21.10 Sep 16, 2021
@sameerz sameerz linked an issue Sep 16, 2021 that may be closed by this pull request
[DOC] Document limitations of RAPIDS Accelerator on Databricks #3449
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs left review comments

@sameerz sameerz sameerz approved these changes

@jlowe jlowe jlowe approved these changes

Assignees

@viadea viadea

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Sep 13 - Sep 24
Development

Successfully merging this pull request may close these issues.

[DOC] Document limitations of RAPIDS Accelerator on Databricks
4 participants
@viadea @sameerz @jlowe @tgravescs