Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move file TestingV2Source.Scala #3674

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Conversation

akbhuker
Copy link
Contributor

Signed-off-by: akbhuker akbhuker49@gmail.com

Signed-off-by: akbhuker <akbhuker49@gmail.com>
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file was moved to com/nvidia/spark/rapids/tests/mortgage, but #3585 is asking for it to be moved to com/nvidia/spark/rapids/tests/datasourcev2/parquet. The directory path should match the package directive at the top of the file with . replaced with /.

@jlowe jlowe added the build Related to CI / CD or cleanly building label Sep 27, 2021
@jlowe jlowe linked an issue Sep 27, 2021 that may be closed by this pull request
@jlowe
Copy link
Member

jlowe commented Sep 28, 2021

build

@tgravescs
Copy link
Collaborator

@akbhuker thanks for the contribution, fyi, for the future, if you put fixes and then the issue number when the pull request is merged it will automatically close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TestingV2Source path does not match package declaration
3 participants