Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce checks for unused imports and missed interpolation [databricks] #4105

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Enforce checks for unused imports and missed interpolation [databricks] #4105

merged 4 commits into from
Nov 16, 2021

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Nov 15, 2021 •
edited
Loading

  • Add compiler flags -Ywarn-unused:imports and -Xlint:missing-interpolator
  • make changes necessary for the build to pass

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov
Enforce checks for unused imports and missed interpolation
54654ef 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov
spark312db fixes
ad73d70 
Signed-off-by: Gera Shegalov <gera@apache.org>
jlowe
jlowe previously approved these changes Nov 15, 2021
View reviewed changes
@jlowe jlowe added the build Related to CI / CD or cleanly building label Nov 15, 2021
@gerashegalov
spark301db done
464f18e 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov added this to the Nov 15 - Nov 26 milestone Nov 15, 2021
@gerashegalov gerashegalov self-assigned this Nov 15, 2021
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov merged commit 2d14428 into NVIDIA:branch-21.12 Nov 16, 2021
@gerashegalov gerashegalov deleted the missingImportsAndInterpolation branch November 16, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

Assignees

@gerashegalov gerashegalov

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Nov 15 - Nov 26
Development

Successfully merging this pull request may close these issues.
2 participants
@gerashegalov @jlowe